refactor: remove voiding of return values when calling functions

+ properly handle errors for individual files

SUGGESTIONS BY AI

src/main.rs

@@ -51,12 +51,16 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
                         continue;
                     }
                     let tag = get_metadata(&path);
-                    let _ = move_files(path, tag.clone(), extra_files.clone(), *copy);
+                    if let Err(e) =
+                        move_files(path.clone(), tag.clone(), extra_files.clone(), *copy)
+                    {
+                        eprintln!("Failed to import {:?}: {}", path, e);
+                    }
                 }
             } else {
                 println!("Importing file: {:?}", file);
                 let tag = get_metadata(file);
-                let _ = move_files(file.clone(), tag.clone(), extra_files, *copy);
+                move_files(file.clone(), tag.clone(), extra_files, *copy)?;
             }
         }
         Commands::Show { file } => {
@@ -70,7 +74,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         Commands::Edit { file } => {
             let path = PathBuf::from("/tmp/keks-sort-metadata");
             let tag = get_metadata(file);
-            let _ = edit(path, tag);
+            edit(path, tag)?;
         }
     }
 

src/move_files.rs

@@ -2,7 +2,7 @@ use glob::glob;
 use lofty::prelude::ItemKey;
 use lofty::tag::Accessor;
 use lofty::tag::Tag;
-use std::fs::{copy, create_dir_all, rename};
+use std::fs::{copy, create_dir_all, remove_dir, rename};
 use std::path::PathBuf;
 
 pub fn move_files(
@@ -32,7 +32,7 @@ pub fn move_files(
     };
 
     let dir_to_create = target_dir.join(artist_dir).join(album_dir.as_ref());
-    let _ = create_dir_all(dir_to_create);
+    create_dir_all(&dir_to_create)?;
     let target = target_dir.join(artist_dir).join(album_dir.as_ref());
 
     let file_name = PathBuf::from(format!(