fix: check free disk space before downloading to prevent silent failure after starting dl

also add "(experimental)" to image path in settings
This commit is contained in:
2026-03-10 21:35:03 +01:00
parent 74e7fcfd70
commit d3d7a9d2ac
2 changed files with 38 additions and 8 deletions
+1 -1
View File
@@ -139,7 +139,7 @@ def settings_dialog(self):
image_path_layout = QHBoxLayout() image_path_layout = QHBoxLayout()
image_path = QLineEdit() image_path = QLineEdit()
image_path_layout.addWidget(QLabel("Image Path (requires restart):")) image_path_layout.addWidget(QLabel("Image Path (requires restart, experimental):"))
image_path_layout.addWidget(image_path) image_path_layout.addWidget(image_path)
image_path_container.setSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Fixed) image_path_container.setSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Fixed)
image_path_container.setLayout(image_path_layout) image_path_container.setLayout(image_path_layout)
+33 -3
View File
@@ -1,5 +1,7 @@
import time import time
import os import os
import platform
import ctypes
from core.utils.general.wrappers import run_thread from core.utils.general.wrappers import run_thread
from core.network.interface import get_interface_ip from core.network.interface import get_interface_ip
import threading import threading
@@ -11,6 +13,15 @@ from core.utils.logging.logs import consoleLog
global loop_running global loop_running
loop_running = False loop_running = False
def get_free_space_mb(dirname):
if platform.system() == 'Windows':
free_bytes = ctypes.c_ulonglong(0)
ctypes.windll.kernel32.GetDiskFreeSpaceExW(ctypes.c_wchar_p(dirname), None, None, ctypes.pointer(free_bytes))
return free_bytes.value
else:
st = os.statvfs(dirname)
return st.f_bavail * st.f_frsize
def init_session(): def init_session():
if state.dl_session is not None: if state.dl_session is not None:
return return
@@ -51,6 +62,8 @@ def add_download(magnet_uri, dl_path=state.download_path):
init_session() init_session()
free_space = get_free_space_mb(state.download_path)
if magnet_uri in state.active_downloads: if magnet_uri in state.active_downloads:
try: try:
handle = state.active_downloads[magnet_uri] handle = state.active_downloads[magnet_uri]
@@ -75,12 +88,30 @@ def add_download(magnet_uri, dl_path=state.download_path):
del state.active_downloads[magnet_uri] del state.active_downloads[magnet_uri]
try: try:
params = lt.parse_magnet_uri(magnet_uri)
params.save_path = "."
handle = state.dl_session.add_torrent(params)
while not handle.has_metadata():
time.sleep(1)
total_size = handle.get_torrent_info().total_size()
if free_space > total_size:
magnetdl = lt.parse_magnet_uri(magnet_uri) magnetdl = lt.parse_magnet_uri(magnet_uri)
magnetdl.save_path = dl_path magnetdl.save_path = dl_path
download = state.dl_session.add_torrent(magnetdl) download = state.dl_session.add_torrent(magnetdl)
except Exception as e: else:
consoleLog(f"Failed to add torrent: {e}") download = None
state.dl_session.remove_torrent(handle)
consoleLog("Not enough free space to download this item.")
return False return False
except Exception as e:
consoleLog(f"Failed to add torrent or fetch info: {e}")
return False
if download:
state.active_downloads[magnet_uri] = download state.active_downloads[magnet_uri] = download
consoleLog(f"Added {magnet_uri} to downloads") consoleLog(f"Added {magnet_uri} to downloads")
@@ -171,4 +202,3 @@ def update_bound_interface():
settings = { "outgoing_interfaces": state.bound_interface } settings = { "outgoing_interfaces": state.bound_interface }
state.dl_session.apply_settings(settings) state.dl_session.apply_settings(settings)