merged upstream, fixed the double tables

src/core/utils/general/shutdown.py

@@ -1,9 +1,10 @@
 import threading
-from core.network.libtorrent_misc import cleanup_session
-from core.utils.general.wrappers import run_thread
+import os
 
 shutdown_event = threading.Event()
 
 def closehelper():
-    run_thread(threading.Thread(target=cleanup_session))
-    shutdown_event.set()
+    shutdown_event.set()
+
+def force_exit():
+    os._exit(0)

src/core/utils/logging/logs.py

@@ -6,23 +6,14 @@ import json
 import os
 import re
 import time
+import threading
 
 _log_buffer = []
+_downloads_lock = threading.RLock()
 
 
 def add_download_log(title, url, magnet_uri, completed) -> DownloadList:
-    downloads_file = os.path.join(state.settings_path, "downloads.json")
-    
-    if os.path.exists(downloads_file) and os.path.getsize(downloads_file) > 0:
-        try:
-            with open(downloads_file, "r") as file:
-                existing_data = json.load(file)
-                downloads = [Download(**d) for d in existing_data.get("data", [])]
-        except json.JSONDecodeError:
-            downloads = []
-    else:
-        downloads = []
-
+    # wait for metadata outside the lock to avoid blocking other threads
     magnetdl = state.active_downloads.get(magnet_uri)
     if magnetdl:
         status = magnetdl.status()
@@ -37,6 +28,21 @@ def add_download_log(title, url, magnet_uri, completed) -> DownloadList:
         path = os.path.join(save_path, torrent_name)
     else:
         path = os.path.join(state.download_path, title)
+    with _downloads_lock:
+        return _add_download_log_inner(title, url, magnet_uri, completed, path)
+
+def _add_download_log_inner(title, url, magnet_uri, completed, path) -> DownloadList:
+    downloads_file = os.path.join(state.settings_path, "downloads.json")
+    
+    if os.path.exists(downloads_file) and os.path.getsize(downloads_file) > 0:
+        try:
+            with open(downloads_file, "r") as file:
+                existing_data = json.load(file)
+                downloads = [Download(**d) for d in existing_data.get("data", [])]
+        except json.JSONDecodeError:
+            downloads = []
+    else:
+        downloads = []
 
     if any(d.magnet_uri == magnet_uri or d.url == url for d in downloads):
         if magnet_uri in state.active_downloads:
@@ -65,6 +71,10 @@ def add_download_log(title, url, magnet_uri, completed) -> DownloadList:
     return download_list
 
 def remove_download_log(magnet_uri) -> DownloadList:
+    with _downloads_lock:
+        return _remove_download_log_inner(magnet_uri)
+
+def _remove_download_log_inner(magnet_uri) -> DownloadList:
     downloads_file = os.path.join(state.settings_path, "downloads.json")
     
     if os.path.exists(downloads_file) and os.path.getsize(downloads_file) > 0:
@@ -91,6 +101,10 @@ def remove_download_log(magnet_uri) -> DownloadList:
     return download_list
 
 def update_download_completed(magnet_uri, completed) -> DownloadList:
+    with _downloads_lock:
+        return _update_download_completed_inner(magnet_uri, completed)
+
+def _update_download_completed_inner(magnet_uri, completed) -> DownloadList:
     downloads_file = os.path.join(state.settings_path, "downloads.json")
     
     if os.path.exists(downloads_file) and os.path.getsize(downloads_file) > 0:
@@ -143,6 +157,10 @@ def update_download_completed(magnet_uri, completed) -> DownloadList:
     
 
 def get_download_logs() -> DownloadList:
+    with _downloads_lock:
+        return _get_download_logs_inner()
+
+def _get_download_logs_inner() -> DownloadList:
     downloads_file = os.path.join(state.settings_path, "downloads.json")
     
     if os.path.exists(downloads_file) and os.path.getsize(downloads_file) > 0:
@@ -166,6 +184,10 @@ def extract_hash_from_magnet(magnet_uri): # full credits to claude for this
 
 
 def update_download_completed_by_hash(info_hash, completed) -> DownloadList:
+    with _downloads_lock:
+        return _update_download_completed_by_hash_inner(info_hash, completed)
+
+def _update_download_completed_by_hash_inner(info_hash, completed) -> DownloadList:
     downloads_file = os.path.join(state.settings_path, "downloads.json")
     
     if os.path.exists(downloads_file) and os.path.getsize(downloads_file) > 0:

src/core/utils/network/download.py

@@ -8,12 +8,19 @@ from core.network.libtorrent_int import add_seed
 import threading
 
 
-def download_selected(item, posts, post_titles):
-    if item is not None:
-        consoleLog(f"Downloading {item.text()}")
-        run_thread(threading.Thread(target=run_download, args=(item.text(), posts, post_titles)))
-    else:
+def download_selected(items, posts, post_titles):
+    if not items:
         consoleLog("No item selected for download.")
+        return
+    seen = set()
+    for item in items:
+        if item.column() != 0:
+            continue
+        text = item.text()
+        if text and text not in seen:
+            seen.add(text)
+            consoleLog(f"Downloading {text}")
+            run_thread(threading.Thread(target=run_download, args=(text, posts, post_titles)))
 
 def run_download(item, posts, post_titles):
     post_url = get_item_url(item, posts, post_titles)

src/core/utils/network/update_checker.py

@@ -17,11 +17,7 @@ def check_for_updates():
     latest_version = latest_release["name"]
     assets = latest_release["assets"]
 
-
-    if state.version == "dev":
-        consoleLog("Dev release detected, skipping version check")
-        return None, None
-    elif latest_version != state.version:
+    if latest_version != state.version:
         consoleLog(f"New release available: {latest_version}")
         if assets:
             consoleLog("Assets:")